Skip to content

SDP 1686 create wallet endpoint update #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

SDP 1686 create wallet endpoint update #696

wants to merge 4 commits into from

Conversation

dpohr
Copy link
Collaborator

@dpohr dpohr commented Jun 4, 2025 •
edited
Loading

What

Update POST wallet endpoint to make it possible accept new asset references,

Why

Create endpoint for the wallet exists but it does not match all requirements, this PR aims to extend POST endpoint capabilities and reduce number of the interaction with the DB directly

Known limitations

Some of the asset types not implemented yet, like fiat or contract

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@dpohr dpohr self-assigned this Jun 4, 2025
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 4, 2025 14:17 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 4, 2025 14:17 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr696.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr696.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr696.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Anchor Integration Tests June 4, 2025 15:10 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 4, 2025 15:10 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr696.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr696.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr696.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 4, 2025 15:22 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 4, 2025 15:22 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr696.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr696.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr696.previews.kube001.services.stellar-ops.com

@dpohr dpohr marked this pull request as ready for review June 4, 2025 19:34
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 5, 2025 13:08 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 5, 2025 13:08 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr696.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr696.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr696.previews.kube001.services.stellar-ops.com

@dpohr dpohr mentioned this pull request Jun 6, 2025
Open
7 tasks
philipliu
philipliu approved these changes Jun 9, 2025
View reviewed changes
internal/serve/validators/wallet_validator.go
@@ -86,6 +124,11 @@ func (wv *WalletValidator) ValidateCreateWalletRequest(ctx context.Context, reqB
wv.Check(false, "sep_10_client_domain", "invalid SEP-10 client domain provided")
}

if reqBody.Enabled == nil {
defEnabled := true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this variable be inlined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipliu philipliu philipliu approved these changes

Assignees

@dpohr dpohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpohr @stellar-jenkins @philipliu